snuyanzin commented on code in PR #22574:
URL: https://github.com/apache/flink/pull/22574#discussion_r1194178109
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala:
##########
@@ -23,17 +23,20 @@ import org.apache.flink.table.api.TableEnvironment
import org.apache.flink.table.api.bridge.scala._
import org.apache.flink.table.planner.runtime.FileSystemITCaseBase
import org.apache.flink.table.planner.runtime.utils.{AbstractExactlyOnceSink,
StreamingTestBase, TestingAppendSink, TestSinkUtil}
+import
org.apache.flink.testutils.junit.extensions.parameterized.NoOpTestExtension
import org.apache.flink.types.Row
-import org.junit.{Assert, Before, Test}
-import org.junit.Assert.assertEquals
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.{BeforeEach, Test}
+import org.junit.jupiter.api.extension.ExtendWith
import scala.collection.{mutable, Seq}
/** Streaming [[FileSystemITCaseBase]]. */
+@ExtendWith(Array(classOf[NoOpTestExtension]))
abstract class StreamFileSystemITCaseBase extends StreamingTestBase with
FileSystemITCaseBase {
Review Comment:
agree about rules, `@after/@before` annotations.
Another point is that `StreamingTestBase` extends another junit4 based
`AbstractTestBase` which has rule
```java
@ClassRule
public static final MiniClusterWithClientResource MINI_CLUSTER_RESOURCE =
new MiniClusterWithClientResource(
new MiniClusterResourceConfiguration.Builder()
.setNumberTaskManagers(1)
.setNumberSlotsPerTaskManager(DEFAULT_PARALLELISM)
.build());
```
it looks like this rule is not required for streaming tests
(`before`/`after` is enough)
please correct me if I'm wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
