godfreyhe commented on code in PR #22566: URL: https://github.com/apache/flink/pull/22566#discussion_r1194510238
########## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperatorTestBase.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.join.stream; + +import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.generated.GeneratedJoinCondition; +import org.apache.flink.table.runtime.keyselector.RowDataKeySelector; +import org.apache.flink.table.runtime.operators.join.stream.state.JoinInputSideSpec; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.runtime.util.RowDataHarnessAssertor; +import org.apache.flink.table.types.logical.CharType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.table.utils.HandwrittenSelectorUtil; + +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.TestInfo; + +/** Base test class for {@link AbstractStreamingJoinOperator}. */ +public abstract class StreamingJoinOperatorTestBase { + + protected final InternalTypeInfo<RowData> leftTypeInfo = + InternalTypeInfo.of( + RowType.of( + new LogicalType[] { + new CharType(false, 20), + new CharType(false, 20), + VarCharType.STRING_TYPE + }, + new String[] {"order_id", "line_order_id", "shipping_address"})); + + protected final InternalTypeInfo<RowData> rightTypeInfo = + InternalTypeInfo.of( + RowType.of( + new LogicalType[] {new CharType(false, 20), new CharType(true, 10)}, + new String[] {"line_order_id0", "line_order_ship_mode"})); + + protected final RowDataKeySelector leftKeySelector = + HandwrittenSelectorUtil.getRowDataSelector( + new int[] {1}, + leftTypeInfo.toRowType().getChildren().toArray(new LogicalType[0])); + protected final RowDataKeySelector rightKeySelector = + HandwrittenSelectorUtil.getRowDataSelector( + new int[] {0}, + rightTypeInfo.toRowType().getChildren().toArray(new LogicalType[0])); + + protected final JoinInputSideSpec leftInputSpec = + JoinInputSideSpec.withUniqueKeyContainedByJoinKey(leftTypeInfo, leftKeySelector); + protected final JoinInputSideSpec rightInputSpec = + JoinInputSideSpec.withUniqueKeyContainedByJoinKey(rightTypeInfo, rightKeySelector); + + protected final InternalTypeInfo<RowData> joinKeyTypeInfo = + InternalTypeInfo.of(new CharType(false, 20)); + + protected final String funcCode = + "public class ConditionFunction extends org.apache.flink.api.common.functions.AbstractRichFunction " + + "implements org.apache.flink.table.runtime.generated.JoinCondition {\n" + + "\n" + + " public ConditionFunction(Object[] reference) {\n" + + " }\n" + + "\n" + + " @Override\n" + + " public boolean apply(org.apache.flink.table.data.RowData in1, org.apache.flink.table.data.RowData in2) {\n" + + " return true;\n" + + " }\n" + + "\n" + + " @Override\n" + + " public void close() throws Exception {\n" + + " super.close();\n" + + " }" + + "}\n"; + protected final GeneratedJoinCondition joinCondition = + new GeneratedJoinCondition("ConditionFunction", funcCode, new Object[0]); + + protected final RowDataHarnessAssertor assertor = + new RowDataHarnessAssertor(getOutputType().getChildren().toArray(new LogicalType[0])); + + protected final long leftStateRetentionTime = 4000L; + protected final long rightStateRetentionTime = 1000L; Review Comment: nit: Do we need to test different RetentionTime ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
