1996fanrui commented on code in PR #22560:
URL: https://github.com/apache/flink/pull/22560#discussion_r1194556471


##########
flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java:
##########
@@ -92,6 +92,17 @@ public class ExecutionOptions {
                     .withDescription(
                             "Tells if we should use compression for the state 
snapshot data or not");
 
+    public static final ConfigOption<Boolean> BUFFER_TIMEOUT_ENABLED =
+            ConfigOptions.key("execution.buffer-timeout.enabled")

Review Comment:
   FLINK-29372 limited that the option key cannot be a prefix of other options, 
however `execution.buffer-timeout` is the prefix of 
`execution.buffer-timeout.enabled`. So the CI fails.
   
   Hi @zentol , could we update the option key for `BUFFER_TIMEOUT` and mark 
the `"execution.buffer-timeout"` as the DeprecatedKey? How about update it to 
`execution.buffer-timeout.interval` ? Or do you have any suggestions here? 
Looking forward to your opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to