Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2683#discussion_r84689406
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1828,6 +1828,33 @@ class JobManager(
jobManagerMetricGroup.gauge[Long, Gauge[Long]]("numRunningJobs", new
Gauge[Long] {
override def getValue: Long = JobManager.this.currentJobs.size
})
+ jobManagerMetricGroup.gauge[Long, Gauge[Long]]("numFailedJobs", new
Gauge[Long] {
+ override def getValue: Long = {
+ var failedJobs = 0
+ val ourJobs = createJobStatusOverview()
+ val future = (archive ?
RequestJobsOverview.getInstance())(timeout)
+ val archivedJobs : JobsOverview = Await.result(future,
timeout).asInstanceOf[JobsOverview]
+ failedJobs += ourJobs.getNumJobsFailed() +
archivedJobs.getNumJobsFailed()
+ failedJobs
+ }})
+ jobManagerMetricGroup.gauge[Long, Gauge[Long]]("numCancelledJobs", new
Gauge[Long] {
+ override def getValue: Long = {
+ var cancelledJobs = 0
+ val ourJobs = createJobStatusOverview()
+ val future = (archive ?
RequestJobsOverview.getInstance())(timeout)
+ val archivedJobs : JobsOverview = Await.result(future,
timeout).asInstanceOf[JobsOverview]
+ cancelledJobs += ourJobs.getNumJobsCancelled() +
archivedJobs.getNumJobsCancelled()
+ cancelledJobs
+ }})
+ jobManagerMetricGroup.gauge[Long, Gauge[Long]]("numFinishedJobs", new
Gauge[Long] {
+ override def getValue: Long = {
+ var finishedJobs = 0
+ val ourJobs = createJobStatusOverview()
+ val future = (archive ?
RequestJobsOverview.getInstance())(timeout)
+ val archivedJobs : JobsOverview = Await.result(future,
timeout).asInstanceOf[JobsOverview]
+ finishedJobs += ourJobs.getNumJobsFinished() +
archivedJobs.getNumJobsFinished()
+ finishedJobs
+ }})
--- End diff --
@zentol What is your take on this change?
I'm uncertain if doing RPC calls in gauges is a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
