reswqa commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204491318
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java:
##########
@@ -173,8 +175,7 @@ private DispatcherGateway
electLeaderAndRetrieveGateway(UUID firstLeaderSessionI
* fail.
*/
@Test
- public void
leaderChange_withBlockingJobManagerTermination_doesNotAffectNewLeader()
- throws Exception {
+ void
leaderChange_withBlockingJobManagerTermination_doesNotAffectNewLeader() throws
Exception {
final TestingJobMasterServiceLeadershipRunnerFactory
jobManagerRunnerFactory =
new TestingJobMasterServiceLeadershipRunnerFactory(1);
final TestingCleanupRunnerFactory cleanupRunnerFactory = new
TestingCleanupRunnerFactory();
Review Comment:
> Here below similar question about dispatcherRunner whether we need it or
not... (in case yes... may just add a comment)
It is also necessary for this test as `dispatcherRunner` will start
`LeaderElectionService` and play the role of `LeaderContender`.
> where some resources are opened without closing... may be put it in try
resource
Done, but I didn't put it in the `try()` where `dispatcherRunner` is located
because it relies on the execution of `dispatcherLeaderElectionService.
isLeader (UUID. randomUUID()). get().` and I don't want to include logic
unrelated to object creation in the try statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
