rkhachatryan commented on code in PR #22685:
URL: https://github.com/apache/flink/pull/22685#discussion_r1211710597


##########
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java:
##########
@@ -333,7 +359,7 @@ public CompletableFuture<JobID> submitJob(@Nonnull JobGraph 
jobGraph) {
                         () -> {
                             try {
                                 final java.nio.file.Path jobGraphFile =
-                                        Files.createTempFile("flink-jobgraph", 
".bin");
+                                        Files.createTempFile(tempDir, 
"flink-jobgraph", ".bin");

Review Comment:
   Maybe also call `deleteOnExit()` on `jobGraphFile`?
   That would cover the case when JVM exits (normally) before the future is 
completed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to