[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

[via GitHub]

zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1212512978


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java:
##########
@@ -324,7 +325,7 @@ public void registerSharedStates(SharedStateRegistry 
stateRegistry, long checkpo
         for (Map.Entry<StateHandleID, StreamStateHandle> sharedStateHandle :
                 sharedState.entrySet()) {
             SharedStateRegistryKey registryKey =
-                    
createSharedStateRegistryKeyFromFileName(sharedStateHandle.getKey());
+                    createSharedStateRegistryKey(sharedStateHandle.getValue());

Review Comment:
   I thought it was just a structural improvement before, but now I realize 
that it was really ill-conceived . We shouldn't be "Pollution first, governance 
later". Thanks for the correction @rkhachatryan .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org