[
https://issues.apache.org/jira/browse/FLINK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605236#comment-15605236
]
ASF GitHub Bot commented on FLINK-4908:
---------------------------------------
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2684
Thank you for your contribution Thomas!
The changes look mostly fine I think, my only concern is the need to cast
the types in lines
[215-216](https://github.com/apache/flink/pull/2684/files#diff-c74d49c94a86f962939a42362f3ea190R215),
I'm not sure if there is a more elegant way to do that.
I'm going to ping @chiwanpark, @mbalassi and @tillrohrmann, if anyone has
some time to review and merge this let us know in the comments.
As a side note, I've noticed that we don't include the evaluate operation
in the documentation of all Predictors, so I've created
[FLINK-4908](https://issues.apache.org/jira/browse/FLINK-4908) to track that.
> Add docs about evaluate operation to all predictors
> ---------------------------------------------------
>
> Key: FLINK-4908
> URL: https://issues.apache.org/jira/browse/FLINK-4908
> Project: Flink
> Issue Type: Improvement
> Components: Machine Learning Library
> Reporter: Theodore Vasiloudis
> Priority: Minor
> Labels: ML
>
> We have added an {{evaluate}} operation to the {{Predictor}} class, making it
> available to all Predictors (SVM, MLR), however their documentation only
> mentions the {{predict}} and {{fit}} operations.
> We should properly document all the available operations for each Predictor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
