Github user thvasilo commented on the issue:

    https://github.com/apache/flink/pull/2684
  
    Thank you for your contribution Thomas!
    
    The changes look mostly fine I think, my only concern is the need to cast 
the types in lines 
[215-216](https://github.com/apache/flink/pull/2684/files#diff-c74d49c94a86f962939a42362f3ea190R215),
 I'm not sure if there is a more elegant way to do that.
    
    I'm going to ping @chiwanpark, @mbalassi and @tillrohrmann, if anyone has 
some time to review and merge this let us know in the comments.
    
    As a side note, I've noticed that we don't include the evaluate operation 
in the documentation of all Predictors, so I've created 
[FLINK-4908](https://issues.apache.org/jira/browse/FLINK-4908) to track that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to