Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2693#discussion_r85079795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
---
@@ -220,4 +220,10 @@ boolean registerListener(NotificationListener
listener) {
throw new IllegalStateException("Already registered
listener.");
}
}
+
+ public int getNumberOfQueuedBuffers() {
+ synchronized (buffers) {
--- End diff --
Can we avoid synchronization here? The metrics should never influence
(block) the other code.
I would rather have the metrics be one off once in a while and avoid the
lock here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
