Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2681
Looks good to me. I think it would be good if @rmetzger also had a look.
Concerning the Table sink tests and the mocking of the producer: Do these
tests need a Kafka cluster running at all? They are just a think layer on top
of the producer, which should be covered with Unit tests and not need a Kafka
cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
