ashangit commented on code in PR #622:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1242157067
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -140,6 +141,12 @@ public UpdateControl<FlinkDeployment>
reconcile(FlinkDeployment flinkApp, Contex
previousDeployment,
false);
}
+ // Rely on the last stable spec if rolling back
+ if (flinkApp.getStatus().getReconciliationStatus().getState()
+ == ReconciliationState.ROLLING_BACK) {
+ flinkApp.setSpec(
+
flinkApp.getStatus().getReconciliationStatus().deserializeLastStableSpec());
Review Comment:
I'm wondering if this is safe to decide to go to upgrade mode if we are
rolling back.
For ex. if we initiate roll back with HA metadata not having being recreated
we will have the job in not `RUNNING` state (should be in `RECONCILING` state).
The operator will failed to deploy as the HA metadata won't be available and
job won't be running
(https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java#L88)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
