snuyanzin commented on code in PR #22558:
URL: https://github.com/apache/flink/pull/22558#discussion_r1243930582


##########
flink-table/flink-sql-jdbc-driver/pom.xml:
##########
@@ -84,6 +84,12 @@
                        <version>${project.version}</version>
                        <scope>test</scope>
                </dependency>
+               <dependency>
+                       <groupId>com.google.guava</groupId>
+                       <artifactId>guava</artifactId>
+                       <version>${guava.version}</version>
+                       <scope>provided</scope>
+               </dependency>

Review Comment:
   yeah, probably you are right
   It seems I was able to find the root cause
   
https://github.com/apache/flink/pull/20931/files#diff-0afcdb67ea32dadfd26f5987cc2ad4b12015cef9481fd05f9129b0eed2e35f61R547-R557
   
   where there is no relocation
   In fact only one is enough for current issue
   ```xml
   <relocation>
        <pattern>com.google</pattern>
        
<shadedPattern>org.apache.flink.calcite.shaded.com.google</shadedPattern>
   </relocation>
   ```
   however i think it's better to keep it in sync with table-planner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to