iceiceiceCN commented on code in PR #22831:
URL: https://github.com/apache/flink/pull/22831#discussion_r1244996088
##########
flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemCommitterTest.java:
##########
@@ -258,6 +263,38 @@ void testPartitionPathNotExist() throws Exception {
assertThat(outputPath.toFile().list()).isEqualTo(new String[0]);
}
+ @Test
+ void testCustomCommitPolicyWithParameters() {
Review Comment:
> Btw, I don't think we need the test in here if we have a IT.
Yeah, it's a good idea, thanks.
I have removed UT here and add IT in `FileSystemTableSinkTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
