[ https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612216#comment-15612216 ]
ASF GitHub Bot commented on FLINK-4552: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2572#discussion_r85360968 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/PurgingTriggerTest.java --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.streaming.runtime.operators.windowing; + +import org.apache.flink.streaming.api.windowing.triggers.PurgingTrigger; +import org.apache.flink.streaming.api.windowing.triggers.Trigger; +import org.apache.flink.streaming.api.windowing.triggers.TriggerResult; +import org.apache.flink.streaming.api.windowing.windows.TimeWindow; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.junit.Test; +import org.mockito.Matchers; +import org.mockito.invocation.InvocationOnMock; +import org.mockito.stubbing.Answer; + +import java.lang.reflect.Method; +import java.util.Collections; + +import static org.apache.flink.streaming.runtime.operators.windowing.WindowOperatorTest.anyOnMergeContext; +import static org.apache.flink.streaming.runtime.operators.windowing.WindowOperatorTest.anyTimeWindow; +import static org.apache.flink.streaming.runtime.operators.windowing.WindowOperatorTest.anyTriggerContext; +import static org.junit.Assert.assertEquals; +import static org.mockito.Matchers.anyLong; +import static org.mockito.Mockito.*; + +/** + * Tests for {@link PurgingTrigger}. + */ +public class PurgingTriggerTest { + + /** + * Check if {@link PurgingTrigger} implements all methods of {@link Trigger}, as a sanity + * check. + */ + @Test + public void testAllMethodsImplemented() throws NoSuchMethodException { --- End diff -- What is the purpose of this and how is it different from checking that PurgingTrigger is not abstract? > Refactor WindowOperator/Trigger Tests > ------------------------------------- > > Key: FLINK-4552 > URL: https://issues.apache.org/jira/browse/FLINK-4552 > Project: Flink > Issue Type: Improvement > Components: Windowing Operators > Reporter: Aljoscha Krettek > Assignee: Aljoscha Krettek > > Right now, tests for {{WindowOperator}}, {{WindowAssigner}}, {{Trigger}} and > {{WindowFunction}} are all conflated in {{WindowOperatorTest}}. All of these > test that a certain combination of a {{Trigger}}, {{WindowAssigner}} and > {{WindowFunction}} produce the expected output. > We should modularize these tests and spread them out across multiple files, > possibly one per trigger, for the triggers. Also, we should extend/change the > tests in some key ways: > - {{WindowOperatorTest}} test should just verify that the interaction > between {{WindowOperator}} and the various other parts works as expected, > that the correct methods on {{Trigger}} and {{WindowFunction}} are called at > the expected time and that snapshotting, timers, cleanup etc. work correctly. > These tests should also verify that the different state types and > {{WindowFunctions}} work correctly. > - {{Trigger}} tests should present elements to triggers and verify that they > fire at the correct times. The actual output of the {{WindowFunction}} is not > important for these tests. We should also test that triggers correctly clean > up state and timers. > - {{WindowAssigner}} tests should test each window assigner and also verify > that, for example, the offset parameter of time-based windows works correctly. > There is already {{WindowingTestHarness}} but it is not used by tests, I > think we can expand on that and provide more thorough test coverage while > also making the tests more maintainable ({{WindowOperatorTest.java}} is > nearing 3000 lines of code). -- This message was sent by Atlassian JIRA (v6.3.4#6332)