zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246058692
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksNativeFullSnapshotStrategy.java:
##########
@@ -219,34 +219,40 @@ public SnapshotResult<KeyedStateHandle>
get(CloseableRegistry snapshotCloseableR
}
}
- private void uploadSstFiles(
- @Nonnull Map<StateHandleID, StreamStateHandle> privateFiles,
+ /** upload files and return total uploaded size. */
+ private long uploadSnapshotFiles(
+ @Nonnull List<HandleAndLocalPath> privateFiles,
Review Comment:
Caller is more complex, maybe it's better to keep the status quo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
