[ 
https://issues.apache.org/jira/browse/FLINK-32522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ran Tao updated FLINK-32522:
----------------------------
    Summary: Kafka connector should depend on commons-collections instead of 
inherit from flink  (was: Flink sql connector kafka should include 
commons-collections in shade jar)

> Kafka connector should depend on commons-collections instead of inherit from 
> flink
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-32522
>                 URL: https://issues.apache.org/jira/browse/FLINK-32522
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka
>    Affects Versions: 1.17.1
>            Reporter: Ran Tao
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2023-07-03-20-15-47-608.png, 
> image-2023-07-03-20-16-03-031.png
>
>
> Currently, externalized sql connector rely on flink main repo. but flink main 
> repo has many test cases(especially in flink-python) reference 
> flink-sql-kafka-connector.
> If we change the dependencies(e.g.  commons-collections) in flink main repo, 
> it cause exception:
> !image-2023-07-03-20-15-47-608.png!
>  
> !https://user-images.githubusercontent.com/11287509/250120522-6b096a4f-83f0-4287-b7ad-d46b9371de4c.png!
>  
> So must add this dependency explicitly. Otherwise, it will cause external 
> connectors block the upgrade of flink main. Connectors shouldn't rely on 
> dependencies that may or may not be
> available in Flink itself. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to