[ https://issues.apache.org/jira/browse/FLINK-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615957#comment-15615957 ]
ASF GitHub Bot commented on FLINK-4910: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2691#discussion_r85570641 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java --- @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.fs; + +import org.apache.flink.util.AbstractCloseableRegistry; +import org.apache.flink.util.IOUtils; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.WrappingProxyUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.lang.ref.PhantomReference; +import java.lang.ref.ReferenceQueue; +import java.util.IdentityHashMap; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; + +/** + * This implementation of an {@link AbstractCloseableRegistry} registers {@link WrappingProxyCloseable}. When + * the proxy becomes subject to GC, this registry takes care of closing unclosed {@link Closeable}s. + * <p> + * Phantom references are used to track when {@link org.apache.flink.util.WrappingProxy}s of {@link Closeable} got + * GC'ed. We ensure that the wrapped {@link Closeable} is proeprly closed to avoid resource leaks. --- End diff -- typo: properly > Introduce safety net for closing file system streams > ---------------------------------------------------- > > Key: FLINK-4910 > URL: https://issues.apache.org/jira/browse/FLINK-4910 > Project: Flink > Issue Type: Improvement > Reporter: Stefan Richter > Assignee: Stefan Richter > > Streams that are opened through {{FileSystem}} must be closed at the end of > their life cycle. However, we found hints that some code forgets to close > such streams. > We should introduce i) a mechanism that closes leaking unclosed streams after > usage and ii) provides logging that helps us to track down and fi the sources > of such leaks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)