TanYuxin-tyx commented on code in PR #22330: URL: https://github.com/apache/flink/pull/22330#discussion_r1161502620
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/tieredstore/upstream/TieredStoreProducerImpl.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.tieredstore.upstream; + +import org.apache.flink.runtime.io.network.buffer.Buffer; +import org.apache.flink.runtime.io.network.buffer.BufferCompressor; +import org.apache.flink.runtime.io.network.partition.tieredstore.upstream.cache.BufferAccumulator; +import org.apache.flink.runtime.io.network.partition.tieredstore.upstream.cache.BufferAccumulatorImpl; +import org.apache.flink.runtime.io.network.partition.tieredstore.upstream.common.StorageTier; +import org.apache.flink.runtime.io.network.partition.tieredstore.upstream.common.TieredStoreProducer; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.nio.ByteBuffer; + +/** + * This is a common entrypoint of emitting records to tiered store. These records will be emitted to + * the {@link BufferAccumulator} to accumulate and transform into finished buffers. + */ +public class TieredStoreProducerImpl implements TieredStoreProducer { + + private final boolean isBroadcastOnly; + + private final int numSubpartitions; + + private final BufferAccumulator bufferAccumulator; + + public TieredStoreProducerImpl( + StorageTier[] storageTiers, + int numSubpartitions, + int bufferSize, + boolean isBroadcastOnly, + @Nullable BufferCompressor bufferCompressor) { + this.isBroadcastOnly = isBroadcastOnly; + this.numSubpartitions = numSubpartitions; + + this.bufferAccumulator = new BufferAccumulatorImpl(); Review Comment: I have updated the producer constructor and made this a constructor argument. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
