hackergin commented on code in PR #22939:
URL: https://github.com/apache/flink/pull/22939#discussion_r1265203862


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkCalciteSqlValidator.java:
##########
@@ -125,4 +160,82 @@ public void validateColumnListParams(
         // this makes it possible to ignore them in the validator and fall 
back to regular row types
         // see also SqlFunction#deriveType
     }
+
+    protected void registerNamespace(
+            @Nullable SqlValidatorScope usingScope,
+            @Nullable String alias,
+            SqlValidatorNamespace ns,
+            boolean forceNullable) {
+
+        // apply snapshot to SqlValidatorNameSpace
+        // Time travel only supports constant expressions, so we need to 
investigate scenarios
+        // where the period of Snapshot is a SqlIdentifier.
+        if (usingScope != null

Review Comment:
   Add a new method getTimeTravelNode to getSnapshotNode instread of  check 
only. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to