twalthr commented on code in PR #22593:
URL: https://github.com/apache/flink/pull/22593#discussion_r1268129439
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java:
##########
@@ -71,20 +75,36 @@
producedTransformations =
StreamExecChangelogNormalize.CHANGELOG_NORMALIZE_TRANSFORMATION,
minPlanVersion = FlinkVersion.v1_15,
minStateVersion = FlinkVersion.v1_15)
+@ExecNodeMetadata(
+ name = "stream-exec-changelog-normalize",
+ version = 2,
Review Comment:
@godfreyhe @luoyuxia @LadyForest If the testing infrastructure would be
already in place, I would agree with increasing the version. But we are not
testing different versions of ExecNode yet. So increasing the annotation has
not effect.
I just noticed that you bumped the ExecNode version of a couple of ExecNodes
for the new state metadata properties in CompiledPlan. Your change actually
allows having null for the stateMetadataList , I'm wondering if we should not
increase the version for 1.18. We can stay at the old ExecNode version as 1.18
is able to consume 1.17 plans and state.
The reason why noticed that is due to FLINK-32613 where I added an option to
the wrong annotation during rebase and no test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
