LadyForest commented on code in PR #22593:
URL: https://github.com/apache/flink/pull/22593#discussion_r1268866818
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java:
##########
@@ -71,20 +75,36 @@
producedTransformations =
StreamExecChangelogNormalize.CHANGELOG_NORMALIZE_TRANSFORMATION,
minPlanVersion = FlinkVersion.v1_15,
minStateVersion = FlinkVersion.v1_15)
+@ExecNodeMetadata(
+ name = "stream-exec-changelog-normalize",
+ version = 2,
Review Comment:
Hi @twalthr, during the implementation of FLIP-292, I did notice that the
current testing for compiled plans is not comprehensive enough, such as
FLINK-31884, FLINK-31917, and FLINK-32219. FLIP-292 added
`ExecNodeVersionUpgradeSerdeTest` and `TransformationsTest#testUidFlink1_15` to
test the deserialization of old plans using the new version, but it may not be
sufficient. After reconsideration, I think we can keep the original exec node
version until we have a more comprehensive testing framework. I will open a PR
and hope you can help review the code. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
