twalthr commented on code in PR #23090: URL: https://github.com/apache/flink/pull/23090#discussion_r1276199023
########## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java: ########## @@ -79,10 +79,8 @@ void testSetAndGetLocalTimeZone() { @Test public void testSetInvalidLocalTimeZone() { assertThatThrownBy(() -> CONFIG_BY_METHOD.setLocalTimeZone(ZoneId.of("UTC-10:00"))) Review Comment: because UTC is actually not a timezone and also UTC-x is not. But GMT somehow is. It is very confusing but luckily we can delegate to JDK mostly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org