Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2723#discussion_r85779839
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -65,7 +65,7 @@ class OptionSerializer[A](val elemSerializer:
TypeSerializer[A])
case Some(a) =>
target.writeBoolean(true)
elemSerializer.serialize(a, target)
- case None =>
+ case _ =>
--- End diff --
If `writeBoolean` is correctly implemented (i.e., according to the JavaDocs
in `java.io.DataOutput#writeBoolean(boolean)`) we should be good. However, you
are right, that we may not change the `0` -> `false` and `1` -> `true` mapping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
