wanglijie95 commented on code in PR #23216: URL: https://github.com/apache/flink/pull/23216#discussion_r1296819120
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ########## @@ -202,6 +202,32 @@ public void testBuildSideIsJoinWithoutExchange() throws Exception { util.verifyPlan(query); } + @Test + public void testBuildSideIsLeftJoinWithoutExchange() throws Exception { Review Comment: After an offline discussion with @lsyldliu , we think it is meaningful to directly inject runtime filter for fact2(let the output of the `LeftOuterJoin` as a builder), even if it will affect the creation of `MultipleInput`. We will keep it as a future optimization, no changes will be made in this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org