ferenc-csaky commented on code in PR #23211:
URL: https://github.com/apache/flink/pull/23211#discussion_r1298692811
##########
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheCleanupTest.java:
##########
@@ -317,20 +303,21 @@ public void testPermanentBlobDeferredCleanup() throws
IOException, InterruptedEx
}
@Test
- public void testTransientBlobNoJobCleanup() throws Exception {
- testTransientBlobCleanup(null);
+ void testTransientBlobNoJobCleanup() throws Exception {
+ testTransientBlobCleanup(tempDir, null);
}
@Test
- public void testTransientBlobForJobCleanup() throws Exception {
- testTransientBlobCleanup(new JobID());
+ void testTransientBlobForJobCleanup() throws Exception {
+ testTransientBlobCleanup(tempDir, new JobID());
}
/**
* Tests that {@link TransientBlobCache} cleans up after a default TTL and
keeps files which are
* constantly accessed.
*/
- private void testTransientBlobCleanup(@Nullable final JobID jobId) throws
Exception {
+ private void testTransientBlobCleanup(final Path tempDir, @Nullable final
JobID jobId)
Review Comment:
We don't, I think this was the first test and I went with the temp dir as a
method param the first time, just forgot to adapted this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
