fredia commented on code in PR #22890: URL: https://github.com/apache/flink/pull/22890#discussion_r1308123867
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorFileMergingManager.java: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.runtime.state; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.JobID; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.checkpoint.filemerging.FileMergingSnapshotManager; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.ShutdownHookUtil; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nonnull; +import javax.annotation.concurrent.GuardedBy; + +import java.util.HashMap; +import java.util.Map; + +/** + * There is one {@link FileMergingSnapshotManager} for each job per task manager. This class holds + * all {@link FileMergingSnapshotManager} objects for a task executor (manager). + */ +public class TaskExecutorFileMergingManager { + /** Logger for this class. */ + private static final Logger LOG = LoggerFactory.getLogger(TaskExecutorFileMergingManager.class); + + /** + * This map holds all FileMergingSnapshotManager for tasks running on this task + * manager(executor). + */ + @GuardedBy("lock") + private final Map<JobID, FileMergingSnapshotManager> fileMergingSnapshotManagerByJobId; + + @GuardedBy("lock") + private boolean closed; + + private final Object lock = new Object(); + + /** Shutdown hook for this manager. */ + private final Thread shutdownHook; + + public TaskExecutorFileMergingManager() { + this.fileMergingSnapshotManagerByJobId = new HashMap<>(); + this.closed = false; + this.shutdownHook = + ShutdownHookUtil.addShutdownHook(this::shutdown, getClass().getSimpleName(), LOG); + } + + /** + * Initialize file merging snapshot manager for each job according configurations when {@link + * org.apache.flink.runtime.taskexecutor.TaskExecutor#submitTask}. + */ + public FileMergingSnapshotManager fileMergingSnapshotManagerForJob( + @Nonnull JobID jobId, + Configuration clusterConfiguration, + Configuration jobConfiguration) { + synchronized (lock) { + if (closed) { + throw new IllegalStateException( + "TaskExecutorFileMergingManager is already closed and cannot " + + "register a new FileMergingSnapshotManager."); + } + FileMergingSnapshotManager fileMergingSnapshotManager = + fileMergingSnapshotManagerByJobId.get(jobId); + if (fileMergingSnapshotManager == null) { + // TODO FLINK-32440: choose different FileMergingSnapshotManager by configuration + LOG.info("Registered new file merging snapshot manager for job {}.", jobId); + } + return fileMergingSnapshotManager; + } + } + + @VisibleForTesting + FileMergingSnapshotManager fileMergingSnapshotManagerForJob( + @Nonnull JobID jobId, FileMergingSnapshotManager mergingSnapshotManager) { Review Comment: After moving file merging initialization into `initializeBaseLocationsForCheckpoint()`, this function is no longer needed, remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
