echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1308521706
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##########
@@ -144,6 +188,17 @@ private void maybeRescale() {
}
}
+ private Duration timeSinceLastRescale() {
+ return Duration.between(lastRescale, Instant.now());
+ }
+
+ private void rescaleWhenCooldownPeriodIsOver() {
Review Comment:
Exactly. This is what I meant and implemented in last commit of yesterday :
the call at 08:01:10 will schedule `maybeRescale` at 08:01:40 and the call at
08:01:15 will not entail any rescale. When `maybeRescale` is executed at
08:01:40, it will use the resources added at 08:01:15 when calling
`Context#getExecutionGraph()`. So that seems fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
