Gerrrr commented on code in PR #46:
URL:
https://github.com/apache/flink-connector-kafka/pull/46#discussion_r1316549706
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -279,7 +279,8 @@ FlinkKafkaInternalProducer<byte[], byte[]>
getCurrentProducer() {
void abortLingeringTransactions(
Collection<KafkaWriterState> recoveredStates, long
startCheckpointId) {
- List<String> prefixesToAbort =
Lists.newArrayList(transactionalIdPrefix);
+ List<String> prefixesToAbort = new ArrayList<>();
Review Comment:
_note_: I did not change this one to `Arrays.asList` because that method
returns an immutable view while `prefixesToAbort` is updated a couple of lines
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
