[ 
https://issues.apache.org/jira/browse/FLINK-33018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762793#comment-17762793
 ] 

Ryan Skraba edited comment on FLINK-33018 at 9/8/23 1:16 PM:
-------------------------------------------------------------

I think I have a fix -- it looks like occasionally (every 10K runs or so) we 
hit the explicit cancel() written in this specific test, before we hit the 
implicit cancel() due to the endofStream message being discovered.  I'm letting 
this run for a while before submitting a PR.  -This test also slows down in 
consecutive runs, which might indicate a leak but I'm hoping this is not the 
case.- (Edit: it's not, it was definitely an IntelliJ issue with conditional 
breakpoints).

I can't seem to _prove_ this is a fix yet, because both IntelliJ and standalone 
maven will eventually segfault when I try to run it 100K times with the 
changes.  I'm looking into it.


was (Author: ryanskraba):
I think I have a fix -- it looks like occasionally (every 10K runs or so) we 
hit the explicit cancel() written in this specific test, before we hit the 
implicit cancel() due to the endofStream message being discovered.  I'm letting 
this run for a while before submitting a PR.  This test also slows down in 
consecutive runs, which might indicate a leak but I'm hoping this is not the 
case.

> GCP Pubsub 
> PubSubConsumingTest.testStoppingConnectorWhenDeserializationSchemaIndicatesEndOfStream
>  failed
> --------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33018
>                 URL: https://issues.apache.org/jira/browse/FLINK-33018
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Google Cloud PubSub
>    Affects Versions: gcp-pubsub-3.0.2
>            Reporter: Martijn Visser
>            Priority: Blocker
>
> https://github.com/apache/flink-connector-gcp-pubsub/actions/runs/6061318336/job/16446392844#step:13:507
> {code:java}
> [INFO] 
> [INFO] Results:
> [INFO] 
> Error:  Failures: 
> Error:    
> PubSubConsumingTest.testStoppingConnectorWhenDeserializationSchemaIndicatesEndOfStream:119
>  
> expected: ["1", "2", "3"]
>  but was: ["1", "2"]
> [INFO] 
> Error:  Tests run: 30, Failures: 1, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> ------------------------------------------------------------------------
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to