gyfora commented on code in PR #666:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/666#discussion_r1320062795
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -365,22 +365,45 @@ public static String operatorConfigKey(String key) {
.withDescription(
"Initial interval of automatic reconcile retries
on recoverable errors.");
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<Duration> OPERATOR_RETRY_MAX_INTERVAL =
+ operatorConfig("retry.max.interval")
+ .durationType()
+ .defaultValue(Duration.ZERO)
+ .withDescription(
+ "Max interval of automatic reconcile retries on
recoverable errors, if set to <=0, no limit is applied.");
+
@Documentation.Section(SECTION_SYSTEM)
public static final ConfigOption<Double>
OPERATOR_RETRY_INTERVAL_MULTIPLIER =
operatorConfig("retry.interval.multiplier")
.doubleType()
- .defaultValue(2.0)
+ .defaultValue(1.5)
Review Comment:
Based on some testing I felt that the current 2 multiplier for the
exponential backoff was a bit too aggressive in some cases. So 1.5 with a
little longer max retries felt more appropriate. If you feel we shouldn't
change this I remove it from the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
