StefanRRichter commented on code in PR #23391:
URL: https://github.com/apache/flink/pull/23391#discussion_r1322653240
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java:
##########
@@ -227,11 +257,23 @@ void reportFailedCheckpoint(FailedCheckpointStats failed)
{
history.replacePendingCheckpointById(failed);
dirty = true;
+ logCheckpointStatistics(failed);
} finally {
statsReadWriteLock.unlock();
}
}
+ private void logCheckpointStatistics(AbstractCheckpointStats
checkpointStats) {
+ try {
+ StringWriter sw = new StringWriter();
+ MAPPER.writeValue(sw,
CheckpointStatistics.generateCheckpointStatistics(checkpointStats, true));
+ String jsonDump = sw.toString();
+ LOG.debug("CheckpointStatistics (for jobID={}, jobName={}) dump =
{} ", jobID, jobName, jsonDump);
+ } catch (Exception ex) {
+ LOG.error("Fail to log CheckpointStatistics", ex);
Review Comment:
I'd also add the job id and name to that message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
