afedulov commented on code in PR #23383:
URL: https://github.com/apache/flink/pull/23383#discussion_r1323172674
##########
flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java:
##########
@@ -100,4 +105,11 @@ public Class<R> getRequestClass() {
public M getUnresolvedMessageParameters() {
return decorated.getUnresolvedMessageParameters();
}
+
+ @Override
+ public Collection<? extends RestAPIVersion<?>> getSupportedAPIVersions() {
Review Comment:
How about simply doing this:
```
@Override
public Collection<? extends RestAPIVersion<?>> getSupportedAPIVersions()
{
return decorated.getSupportedAPIVersions();
}
```
this class has a clear purpose of only decorating the URL, without dealing
with anything related to the features of the decorated object. This change
would also make the `SQLGatewayUrlPrefixDecorator` redundant - the SQL headers
that get decorated will simply pass their `SqlGatewayRestAPIVersion.values()`
from `SqlGatewayMessageHeaders` which they already extend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
