morhidi commented on code in PR #670:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1323382871


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java:
##########
@@ -478,6 +478,50 @@ public void testTaskManagerSpec() {
                 Double.valueOf(1), 
configuration.get(KubernetesConfigOptions.TASK_MANAGER_CPU));
     }
 
+    @Test
+    public void testApplyJobManagerSpecWithBiByteMemorySetting() {

Review Comment:
   We'll probably need a bit more test cases here once we understand what do we 
exactly want, see my comments above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to