architgyl commented on code in PR #23164:
URL: https://github.com/apache/flink/pull/23164#discussion_r1323745882
##########
flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java:
##########
@@ -143,6 +165,22 @@ private static Map<String, String> getLibJars() {
return libJars;
}
+ private static Map<String, String> getFilesWithParentDir() {
+ final Map<String, String> filesWithParentDir = new HashMap<>(2);
+ final String xmlContent = "XML Content";
+
+ filesWithParentDir.put("conf/hive-site.xml", xmlContent);
+ filesWithParentDir.put("conf/ivysettings.xml", xmlContent);
+
+ return filesWithParentDir;
+ }
+
+ private static List<String> getExpectedClassPathWithParentDir() {
Review Comment:
Done.
##########
flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java:
##########
@@ -143,6 +165,22 @@ private static Map<String, String> getLibJars() {
return libJars;
}
+ private static Map<String, String> getFilesWithParentDir() {
Review Comment:
Done.
##########
flink-yarn/src/test/java/org/apache/flink/yarn/YarnApplicationFileUploaderTest.java:
##########
@@ -73,6 +73,28 @@ void testRegisterProvidedLocalResources(@TempDir File
flinkLibDir) throws IOExce
}
}
+ @Test
+ void testRegisterProvidedLocalResourcesWithParentDir(@TempDir File
flinkLibDir)
+ throws IOException {
+ final Map<String, String> filesWithParentDir = getFilesWithParentDir();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
