[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #23404: [FLINK-33076][network] Reduce serialization overhead of broadcast emit from ChannelSelectorRecordWriter.

[via GitHub]

TanYuxin-tyx commented on code in PR #23404:
URL: https://github.com/apache/flink/pull/23404#discussion_r1323910378


##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java:
##########
@@ -132,35 +132,34 @@ public void testRandomEmitAndBufferRecycling() throws 
Exception {
         List<Buffer> buffers =
                 Arrays.asList(bufferPool.requestBuffer(), 
bufferPool.requestBuffer());
         buffers.forEach(Buffer::recycleBuffer);
-        assertEquals(3, bufferPool.getNumberOfAvailableMemorySegments());
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(3);
 
         // fill first buffer
         writer.broadcastEmit(new IntType(1));
         writer.broadcastEmit(new IntType(2));
-        assertEquals(2, bufferPool.getNumberOfAvailableMemorySegments());
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(2);
 
         // simulate consumption of first buffer consumer; this should not free 
buffers
-        assertEquals(1, partition.getNumberOfQueuedBuffers(0));
+        assertThat(partition.getNumberOfQueuedBuffers(0)).isEqualTo(1);

Review Comment:
   We can simplify this.
   ```suggestion
           assertThat(partition.getNumberOfQueuedBuffers(0)).isOne();
   ```



##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java:
##########
@@ -132,35 +132,34 @@ public void testRandomEmitAndBufferRecycling() throws 
Exception {
         List<Buffer> buffers =
                 Arrays.asList(bufferPool.requestBuffer(), 
bufferPool.requestBuffer());
         buffers.forEach(Buffer::recycleBuffer);
-        assertEquals(3, bufferPool.getNumberOfAvailableMemorySegments());
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(3);
 
         // fill first buffer
         writer.broadcastEmit(new IntType(1));
         writer.broadcastEmit(new IntType(2));
-        assertEquals(2, bufferPool.getNumberOfAvailableMemorySegments());
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(2);
 
         // simulate consumption of first buffer consumer; this should not free 
buffers
-        assertEquals(1, partition.getNumberOfQueuedBuffers(0));
+        assertThat(partition.getNumberOfQueuedBuffers(0)).isEqualTo(1);
         ResultSubpartitionView view0 =
                 partition.createSubpartitionView(0, new 
NoOpBufferAvailablityListener());
         closeConsumer(view0, 2 * recordSize);
-        assertEquals(2, bufferPool.getNumberOfAvailableMemorySegments());
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(2);
 
         // use second buffer
         writer.emit(new IntType(3), 0);
-        assertEquals(1, bufferPool.getNumberOfAvailableMemorySegments());
-
+        
assertThat(bufferPool.getNumberOfAvailableMemorySegments()).isEqualTo(1);
         // fully free first buffer
-        assertEquals(1, partition.getNumberOfQueuedBuffers(1));
+        assertThat(partition.getNumberOfQueuedBuffers(1)).isEqualTo(1);

Review Comment:
   ```suggestion
           assertThat(partition.getNumberOfQueuedBuffers(1)).isOne();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org