venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324916866
########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ########## @@ -395,9 +397,19 @@ class RexNodeToExpressionConverter( inputNames: Array[String], functionCatalog: FunctionCatalog, catalogManager: CatalogManager, - timeZone: TimeZone) + timeZone: TimeZone, + relDataType: Option[RelDataType] = None) extends RexVisitor[Option[ResolvedExpression]] { + def this( + rexBuilder: RexBuilder, + inputNames: Array[String], + functionCatalog: FunctionCatalog, + catalogManager: CatalogManager, + timeZone: TimeZone) = { + this(rexBuilder, inputNames, functionCatalog, catalogManager, timeZone, null) Review Comment: I think `None` or `null` is required without which scala compiler fails with `constructor invokes itself` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org