FangYongs commented on code in PR #23301:
URL: https://github.com/apache/flink/pull/23301#discussion_r1328266864


##########
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/AsyncCallsTest.java:
##########
@@ -117,22 +113,22 @@ private void 
runScheduleWithNoDelayTest(RpcEndpointFactory factory) throws Excep
                             Duration.ofSeconds(30L));
 
             String str = result.get(30, TimeUnit.SECONDS);
-            assertEquals("test", str);
+            assertThat(str).isEqualTo("test");
 
             // validate that no concurrent access happened
-            assertFalse("Rpc Endpoint had concurrent access", 
concurrentAccess.get());
+            assertThat(concurrentAccess).isFalse();

Review Comment:
   Use `assertThat(...).withFailMessage("Rpc Endpoint had concurrent 
access").isFalse()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to