Jiabao-Sun commented on code in PR #23358:
URL: https://github.com/apache/flink/pull/23358#discussion_r1329983585
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/DecimalTypeTest.scala:
##########
@@ -385,11 +385,11 @@ class DecimalTypeTest extends ExpressionTestBase {
testAllApis((-'f51).round(1), "round(-f51,1)", "-100.0")
- testAllApis(('f51).round(-1), "round(f51,-1)", "100")
Review Comment:
Thanks yuxia.
I think it would be better to remove the parentheses. There are also similar
code snippets without parentheses in the code above.
```java
testAllApis('f50.round(-1), "round(f50,-1)", "650")
testAllApis('f50.round(-2), "round(f50,-2)", "600")
testAllApis('f50.round(-3), "round(f50,-3)", "1000")
testAllApis('f50.round(-4), "round(f50,-4)", "0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
