tzulitai commented on code in PR #20:
URL:
https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1332045177
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java:
##########
@@ -98,20 +98,24 @@
private final KafkaRecordDeserializationSchema<OUT> deserializationSchema;
// The configurations.
private final Properties props;
+ // Client rackId callback
+ private final Supplier<String> rackIdSupplier;
Review Comment:
I think we must address this before we merge this PR.
At the very least, the `Supplier` needs to be serializable.
You can use the `SerializableSupplier` interface from Flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
