dannycranmer commented on code in PR #94:
URL:
https://github.com/apache/flink-connector-aws/pull/94#discussion_r1338172936
##########
flink-connector-aws-e2e-tests/flink-connector-aws-kinesis-streams-e2e-tests/src/test/java/org/apache/flink/connector/kinesis/testutils/AWSEndToEndTestUtils.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.flink.connector.kinesis.testutils;
Review Comment:
Missing copyright header
##########
flink-connector-aws-e2e-tests/flink-connector-aws-kinesis-streams-e2e-tests/src/test/java/org/apache/flink/connector/kinesis/testutils/AWSKinesisResourceManager.java:
##########
@@ -0,0 +1,106 @@
+package org.apache.flink.connector.kinesis.testutils;
Review Comment:
Missing copyright header
##########
flink-connector-aws-e2e-tests/flink-connector-aws-kinesis-streams-e2e-tests/src/test/java/org/apache/flink/connector/kinesis/testutils/AWSKinesisResourceManager.java:
##########
@@ -0,0 +1,106 @@
+package org.apache.flink.connector.kinesis.testutils;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import software.amazon.awssdk.services.kinesis.KinesisClient;
+import software.amazon.awssdk.services.kinesis.model.CreateStreamRequest;
+import software.amazon.awssdk.services.kinesis.model.DeleteStreamRequest;
+import software.amazon.awssdk.services.kinesis.model.DescribeStreamRequest;
+import software.amazon.awssdk.services.kinesis.model.DescribeStreamResponse;
+import software.amazon.awssdk.services.kinesis.model.StreamMode;
+import software.amazon.awssdk.services.kinesis.model.StreamModeDetails;
+import software.amazon.awssdk.services.kinesis.model.StreamSummary;
+import software.amazon.awssdk.services.kinesis.paginators.ListStreamsIterable;
+import software.amazon.awssdk.services.kinesis.waiters.KinesisWaiter;
+
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.UUID;
+
+/** Resource manager to create and clean up Kinesis Data Stream resources used
for each test. */
+public class AWSKinesisResourceManager {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(AWSKinesisResourceManager.class);
+
+ private static final String KINESIS_DATA_STREAMS_NAME_PREFIX =
"flink-test-";
+ private static final int DEFAULT_SHARD_COUNT = 1;
+ private final KinesisClient kinesisClient;
+ private final KinesisWaiter kinesisWaiter;
+ private final Set<String> kinesisDataStreamARNs = new HashSet<>();
+
+ public AWSKinesisResourceManager(KinesisClient kinesisClient) {
+ this.kinesisClient = kinesisClient;
+ this.kinesisWaiter =
KinesisWaiter.builder().client(kinesisClient).build();
+ }
+
+ public String createKinesisDataStream() {
+ String streamName = KINESIS_DATA_STREAMS_NAME_PREFIX +
UUID.randomUUID();
+ LOGGER.info("Creating Kinesis Data Stream with name {}.", streamName);
+ kinesisClient.createStream(
+ CreateStreamRequest.builder()
+ .streamName(streamName)
+ .shardCount(DEFAULT_SHARD_COUNT)
+ .streamModeDetails(
+ StreamModeDetails.builder()
+ .streamMode(StreamMode.PROVISIONED)
+ .build())
+ .build());
+ DescribeStreamResponse response =
+ kinesisClient.describeStream(
+
DescribeStreamRequest.builder().streamName(streamName).build());
+ String streamARN = response.streamDescription().streamARN();
+ kinesisDataStreamARNs.add(streamARN);
+ LOGGER.info("Successfully created Kinesis Data Stream with ARN {}.",
streamARN);
+
+ LOGGER.info("Waiting until Kinesis Data Stream with ARN {} is
ACTIVE.", streamARN);
+ kinesisWaiter.waitUntilStreamExists(
Review Comment:
Just checking this waits for stream to be ACTIVE? It is not too clear from
the
[docs](https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/kinesis/waiters/KinesisWaiter.html#waitUntilStreamExists(java.util.function.Consumer,java.util.function.Consumer))
##########
flink-connector-aws-e2e-tests/flink-connector-aws-kinesis-streams-e2e-tests/src/test/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkITCase.java:
##########
@@ -0,0 +1,357 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.sink;
+
+import org.apache.flink.api.common.serialization.SerializationSchema;
+import org.apache.flink.api.common.serialization.SimpleStringSchema;
+import org.apache.flink.connector.aws.testutils.AWSServicesTestUtils;
+import org.apache.flink.connector.aws.util.AWSGeneralUtil;
+import org.apache.flink.connector.kinesis.testutils.AWSEndToEndTestUtils;
+import org.apache.flink.connector.kinesis.testutils.AWSKinesisResourceManager;
+import org.apache.flink.runtime.client.JobExecutionException;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import
org.apache.flink.streaming.api.functions.source.datagen.DataGeneratorSource;
+import org.apache.flink.streaming.api.functions.source.datagen.RandomGenerator;
+import org.apache.flink.test.junit5.MiniClusterExtension;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
+import software.amazon.awssdk.http.SdkHttpClient;
+import software.amazon.awssdk.services.kinesis.KinesisClient;
+import software.amazon.awssdk.services.kinesis.model.GetRecordsRequest;
+import software.amazon.awssdk.services.kinesis.model.GetShardIteratorRequest;
+import software.amazon.awssdk.services.kinesis.model.ShardIteratorType;
+
+import java.util.Properties;
+
+import static
org.apache.flink.connector.aws.config.AWSConfigConstants.AWS_ENDPOINT;
+
+/** End-to-end tests for Kinesis Data Streams Sink. */
+@ExtendWith(MiniClusterExtension.class)
+@Execution(ExecutionMode.CONCURRENT)
+@Tag("requires-aws-credentials")
+class KinesisStreamsSinkITCase {
+
+ private static final String DEFAULT_FIRST_SHARD_NAME =
"shardId-000000000000";
+
+ private final SerializationSchema<String> serializationSchema = new
SimpleStringSchema();
+ private final PartitionKeyGenerator<String> partitionKeyGenerator =
+ element -> String.valueOf(element.hashCode());
+ private final PartitionKeyGenerator<String> longPartitionKeyGenerator =
element -> element;
+
+ private StreamExecutionEnvironment env;
+ private SdkHttpClient httpClient;
+ private KinesisClient kinesisClient;
+ private AWSKinesisResourceManager kinesisResourceManager;
+
+ @BeforeEach
+ void setUp() {
+ env = StreamExecutionEnvironment.getExecutionEnvironment();
+ env.setParallelism(1);
+
+ httpClient = AWSServicesTestUtils.createHttpClient();
+ kinesisClient =
+ AWSEndToEndTestUtils.createAwsSyncClient(httpClient,
KinesisClient.builder());
+ kinesisResourceManager = new AWSKinesisResourceManager(kinesisClient);
+ }
+
+ @AfterEach
+ void teardown() {
+ kinesisResourceManager.close();
+ AWSGeneralUtil.closeResources(httpClient, kinesisClient);
Review Comment:
Should we run `cleanUpStaleKinesisDataStreams();` on `@AfterClass` as to
speed up the tests? And possibly on `@BeforeClass` incase the tests starts
failing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
