XComp commented on code in PR #23506:
URL: https://github.com/apache/flink/pull/23506#discussion_r1354814278


##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -167,6 +167,8 @@ public class HighAvailabilityOptions {
                     .withDescription(
                             "Defines the number of connection retries before 
the client gives up.");
 
+    /** @deprecated Don't use this option anymore. It has no effect on Flink. 
*/
+    @Deprecated
     
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
     public static final ConfigOption<String> 
ZOOKEEPER_RUNNING_JOB_REGISTRY_PATH =

Review Comment:
   hm, I wanted to reproduce it but failed. How did you generate the docs?
   I tried the what's documented in 
[docs/README.md:62](https://github.com/apache/flink/blob/5c1e9f3b1449cb77276d578b344d9a69c7cf9a3c/docs/README.md#L62):
   ```bash
   mvn -Pgenerate-config-docs install -Dfast -DskipTests
   ```
   and what's documented in 
[flink-docs/README.md:44](https://github.com/apache/flink/blob/7bebd2d9fac517c28afc24c0c034d77cfe2b43a6/flink-docs/README.md#L44)
   ```bash
   mvn package -Dgenerate-config-docs -pl flink-docs -am -nsu -DskipTests
   ```
   Both approaches didn't regenerated the HTML files after reverting your 
change. What am I missing? :thinking: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to