afedulov commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1354883300
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass>
containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given
type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully
qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the
stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?>
clazz) {
Review Comment:
Good point! I ran a script to search for the following methods
```
areFieldOfType
arePublicFinalOfType
arePublicStaticOfType
arePublicStaticFinalOfType
arePublicFinalOfTypeWithAnnotation
arePublicStaticFinalOfTypeWithAnnotation
areStaticFinalOfTypeWithAnnotation
```
across these repositories
```
apache/flink-connector-kafka
apache/flink-connector-cassandra
apache/flink-connector-elasticsearch
apache/flink-connector-rabbitmq
apache/flink-connector-google-cloud-pubsub
apache/flink-connector-pulsar
apache/flink-connector-jdbc
apache/flink-connector-hbase
apache/flink-connector-hive
apache/flink-connector-aws
apache/flink-connector-firehose
apache/flink-connector-kinesis
apache/flink-connector-dynamodb
```
and did not find any usage.
It seems that the question "Does this change in Flink break any connector?"
will be a recurring topic with the externalized repos. Having some automated
checks is tricky, but feasible:
1) get all the method signature changes in the PR
2) search across the connector repos for usage of the respective classes +
methods
The experience I just made is that using GitHub API won't work due to
pretty heavy throttling on their side. What do, will checking out all the
connector repos in the main Flink CI run work for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
