Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2653#discussion_r86540020
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/EvaluableFunction.scala
 ---
    @@ -0,0 +1,62 @@
    +/*
    --- End diff --
    
    Whether you can remove the EvaluableFunction.scala, and then move 
getEvalMethods method and getSignatures method to 
UserDefinedFunctionUtils.scala, for example:
    1. change checkAndExtractEvalMethods() to def 
checkAndExtractEvalMethods(clazz: Class[_]): Array[Method] = {...}
    2. change getSignatures: Array[Array[Class[_]]] to getSignatures(clazz: 
Class[_]): Array[Array[Class[_]]] = {...}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to