Jiabao-Sun commented on code in PR #23515:
URL: https://github.com/apache/flink/pull/23515#discussion_r1361042492


##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java:
##########
@@ -300,6 +303,8 @@ void testCancelExecutionInteractiveMode() throws Exception {
                                 try {
                                     client.executeInInteractiveMode();
                                 } catch (Exception ignore) {
+                                } finally {

Review Comment:
   Thanks @XComp for the review. It makes sense to me.
   I found that `CheckedThread` can solve this problem as well. 
   Would you mind helping review it again?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to