[ 
https://issues.apache.org/jira/browse/FLINK-32397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777658#comment-17777658
 ] 

luoyuxia edited comment on FLINK-32397 at 10/20/23 9:29 AM:
------------------------------------------------------------

[~twalthr] Hi, sorry for the confusion. But in FLINK-27237, we did intend to 
start a FLIP discuss for it, but it turned out it has been voted in FLIP-63 as 
the comments in FLINK-27237 said.

It's expected that the comma is missing as  the description in FLINK-27237 
show.  We also have investigated some pupular engines for big data, they did no 
comma between partitions in {{alter table add partition}} statemetn.

Spark: 
[https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html]

Hive: 
[https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g#L248]

aws: 
[https://docs.aws.amazon.com/athena/latest/ug/alter-table-add-partition.html|https://docs.aws.amazon.com/athena/latest/ug/alter-table-add-partition.html.]

So, I think the current behavior may be reasonable since it‘s compatible with 
known engines.

But in the doc of FLIP-63, it seems it did have a comma. I'd think may be a 
mistake in the doc of FLIP-63.

cc [~lsy] @[Jingsong 
Lee|https://cwiki.apache.org/confluence/display/~jingsonglee0]


was (Author: luoyuxia):
[~twalthr] Hi, sorry for the confusion. But in FLINK-27237, we did intend to 
start a FLIP discuss for it, but it turned out it has been voted in FLIP-63 as 
the comments in FLINK-27237 said.

It's expected that the comma is missing as  the description in FLINK-27237 
show.  We also have investigated some pupular engines for big data, they did no 
comma between partitions in {{alter table add partition}} statemetn.

Spark: 
[https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html]

Hive: 
https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g#L248

aws: 
[https://docs.aws.amazon.com/athena/latest/ug/alter-table-add-partition.html|https://docs.aws.amazon.com/athena/latest/ug/alter-table-add-partition.html.]

So, I think the current behavior may be reasonable since it‘s compatible with 
known engines.

But in the doc of FLIP-63, it seems it did have a comma. I'd think may be a 
mistake in the doc of FLIP-63.

> Add doc for add/drop/show partition
> -----------------------------------
>
>                 Key: FLINK-32397
>                 URL: https://issues.apache.org/jira/browse/FLINK-32397
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Documentation
>            Reporter: luoyuxia
>            Assignee: Hang Ruan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to