srpraneeth commented on PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#issuecomment-1776165715
> Hey @srpraneeth ! Sorry for iterating too much on this :) > > I think it would actually make sense to (instead of implementing the FlinkResourceValidator interface) simply embed this logic into the DefaultValidator. > > We could then just keep the `validateAutoScalerFlinkConfiguration` as a static utility and call it from the `DefaultValidator` . > > That way we benefit from the config handling already present in the DefaultValidator that properly handles / default and config overrides. We would also avoid these costly conversions between configs/maps etc. > > Furthermore the config validation utility then can be moved to the autoscaler module where it logically belongs and other autoscaler imeplementaitons can also use it in the future (not only Kubernetes). I think this would simplify the code a lot actually and make the whole thing better. @gyfora Thanks for the thoroughly checking on PR. Agree this makes complete sense. I will move the autoscaler validation to the DefaultValidator and update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
