dalelane commented on code in PR #23395:
URL: https://github.com/apache/flink/pull/23395#discussion_r1369858784
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroDeserializationSchema.java:
##########
@@ -53,22 +55,25 @@ public class AvroDeserializationSchema<T> implements
DeserializationSchema<T> {
* schema.
*
* @param schema schema of produced records
+ * @param encoding Avro serialization approach to use for decoding
* @return deserialized record in form of {@link GenericRecord}
*/
- public static AvroDeserializationSchema<GenericRecord> forGeneric(Schema
schema) {
- return new AvroDeserializationSchema<>(GenericRecord.class, schema);
+ public static AvroDeserializationSchema<GenericRecord> forGeneric(
Review Comment:
Thanks very much for catching that - I've added a wrapper for these methods
that maintains the previous API signature. I'd done that for constructors but
missed these, apologies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
