dawidwys commented on code in PR #23520: URL: https://github.com/apache/flink/pull/23520#discussion_r1370180311
########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/ExtraCalciteResource.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.calcite.sql.validate; + +import org.apache.calcite.runtime.Resources; + +/** + * Compiler-checked resources similar to CalciteResource in Calcite project, to improve error + * message for functions without matching signature. Ref: Review Comment: Isn't this a bit too specific for `validatorNoFunctionMatch`? Should we rather phrase it that those are extra exceptions that we want to extend Calcite with? Just in case someone adds more resources here. ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java: ########## @@ -209,6 +209,47 @@ public static TableException createUnexpectedException( cause); } + /** + * Validates argument counts. + * + * @param argumentCount expected argument count + * @param actualCount actual argument count + * @param throwOnFailure boolean indicating whether a ValidationException must be thrown or not Review Comment: how about we're a bit more specific? ```suggestion * @param throwOnFailure if true, the function throws a {@link ValidationException} if the actual value does not meet the expected argument count ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
