victor9309 commented on PR #23528:
URL: https://github.com/apache/flink/pull/23528#issuecomment-1778610263

   Thanks @XComp for the review.  
   
   I test to execute the next attempt when it fails
   
   > can you double-check that wget works properly (i.e. returns an non-zero 
exit code) if accessing the website fails? ...to make the retry logic work.
   
   
![image](https://github.com/apache/flink/assets/18453843/f5b19771-5ef0-4e78-bdd7-fee151e7ccb6)
   
   The only parameter to modify is to execute the downloaded command, which 
makes it more intuitive.
   > shouldn't we be able to generalize it even more? We could move the actual 
download logic into this function as well. The only parameter that should be 
passed would be the URL of the artifact. WDYT?
   
   
![image](https://github.com/apache/flink/assets/18453843/73b328ce-9eda-453b-bb68-d100fa490178)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to